Resolver Specific Parameters (ID5 Mobile In-App)#40
Open
Riabkov wants to merge 6 commits into
Open
Conversation
- Add hids, bundle, ver, ua, id5_signature to targeting API - Add AppInfoHolder.kt for bundle and appVersion - Add id5_signature to LocalStorage.kt
- Update unit tests
A single malformed entry early in eids no longer aborts the scan and silently drops a valid ID5 entry that follows it.
WebView(context) requires the main thread; constructing the SDK off it silently dropped both the ua param and the User-Agent header, which ID5 resolution depends on. WebSettings.getDefaultUserAgent works on any thread and avoids constructing a WebView.
- stray space before comma in the targeting call - README hint example used Apple-only identifiers (IDFA/IDFV) on Android - README: note that any identifier type is forwarded as a hint as-is, consumption is decided server-side - stale test comment referencing a nonexistent gate
mosherBT
reviewed
Jul 24, 2026
|
|
||
| - `bundle` — the app's package name. | ||
| - `ver` — the app's version name. | ||
| - `ua` — the device user agent (the same value sent in the `User-Agent` header; overridable via `customUserAgent`). |
There was a problem hiding this comment.
Do GDPR signals already come through the android SDK?
|
I will merge this PR to add a template to this repo. Can you fill out some more info the description please. Nothing big just brief |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #39